Add CI/CD and implement the first two rules #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh
added
the
isState:ForCCBReview
Signed-off-by: hoangtungdinh <[email protected]> Signed-off-by: hoangtungdinh <[email protected]>
pmai
approved these changes
Jun 20, 2024
|
@pmai, the reason we keep the original implementation is that it is easier to access and use as a reference when implementing the rule, as we don't have to search the commit history or another branch to find the original implementation. However, I can see that it causes confusion. We will remove the original implementation in the next sprint. |
Signed-off-by: hoangtungdinh <[email protected]>
|
I am closing this PR as we now have #27 carrying all the commits from this PR. |
andreaskern74
removed
the
isState:ForCCBReview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is ready for CCB's review.
This PR sets up the structure of the repository, creates CI/CD and implements the first two rules using the Python Base Library.
Main changes
original_implementationfolder so that it can still be easily accessed and used as the reference implementation for the new rules. Towards the end of the project, the folderoriginal_implementationwill be removed.How was the PR tested?
Notes
This PR will close the following issues: